Skip to content

(builld) Adjust TeamCity "pullRequests" build feature#3838

Closed
Windos wants to merge 1 commit intochocolatey:developfrom
Windos:build/adjust-pullrequests-settings
Closed

(builld) Adjust TeamCity "pullRequests" build feature#3838
Windos wants to merge 1 commit intochocolatey:developfrom
Windos:build/adjust-pullrequests-settings

Conversation

@Windos
Copy link
Member

@Windos Windos commented Jan 27, 2026

Description Of Changes

This PR makes two changes to this project's TeamCity build configuration:

  • Sets TeamCity to ignore draft PRs. This saves on CI time for builds that are not yet ready to be worked on.
  • Sets TeamCity to only build PRs that have been authored by organization members. This ensures that untrusted code will not be run in CI automatically.

Motivation and Context

The purpose of this PR is to discuss these changes which may be rolled out to other GitHub based projects.

Testing

N/A

This change has been synced onto a test TeamCity instance to validate syntax and that the intended settings have applied.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

@Windos Windos requested a review from gep13 January 27, 2026 03:57
@Windos Windos self-assigned this Jan 27, 2026
Sets TeamCity to ignore draft PRs.
This saves on CI time for builds that are not yet ready to be worked on.
Sets TeamCity to only build PRs that have been authored by
organization members.
This ensures that untrusted code will not be run in CI automatically.
@Windos Windos force-pushed the build/adjust-pullrequests-settings branch from 2a930bc to e5e07a8 Compare January 27, 2026 04:49
@Windos Windos marked this pull request as draft January 27, 2026 04:53
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Windos
Copy link
Member Author

Windos commented Feb 3, 2026

Closing as this does not work as hoped and won't achieve the goal of making this change.

@Windos Windos closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants