Skip to content

Disable the barostat during FIRE minimization #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikemhenry merged 5 commits into from
Apr 22, 2025
Merged

Disable the barostat during FIRE minimization #773

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4596780
Disable the barostat during FIRE minimization
hannahbaumann Mar 26, 2025
0985906
Disable pressure instead of barostat frequency
hannahbaumann Mar 27, 2025
a3c3fde
Update openmmtools/integrators.py
hannahbaumann Mar 31, 2025
3724149
Merge branch 'main' into disable_barostat_fire
mikemhenry Apr 3, 2025
49c7c07
Merge branch 'main' into disable_barostat_fire
mikemhenry Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions openmmtools/multistate/multistatesampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,12 @@ def _minimize_replica(self, replica_id, tolerance, max_iterations):
# Retrieve thermodynamic and sampler states.
thermodynamic_state_id = self._replica_thermodynamic_states[replica_id]
thermodynamic_state = self._thermodynamic_states[thermodynamic_state_id]

# Temporarily disable the barostat during minimization.
# Otherwise, the minimizer will modify the box
# vectors and may cause instabilities.
pressure = thermodynamic_state.pressure
thermodynamic_state.pressure = None
sampler_state = self._sampler_states[replica_id]

# Use the FIRE minimizer
Expand Down Expand Up @@ -1397,6 +1403,9 @@ def _minimize_replica(self, replica_id, tolerance, max_iterations):

# Get the minimized positions.
sampler_state.update_from_context(context)

# Restore the barostat
thermodynamic_state.pressure = pressure

# Compute the final energy of the system for logging.
final_energy = thermodynamic_state.reduced_potential(sampler_state)
Expand Down