Use strict equality for tokenizer backend checks in decode_batch

[anaslimem]

Fix tokenizer backend checks to use strict equality instead of substring matching

Problem

The decode_batch method in tokenizer.py was using substring checks (in) instead of exact equality (==) for backend validation:

elif self._backend in "tiktoken":  # Wrong - substring check
elif self._backend in "tokenizers":  # Wrong - substring check

Issues with substring matching

• Brittle: If backend names change (e.g., "tiktoken_v2"), it could still match incorrectly
• Inconsistent: All other backend checks in the codebase use ==
• Potential bugs: Could route to wrong decoding method if backend names are refactored

Solution

Changed to strict equality checks for consistency and correctness:

elif self._backend == "tiktoken":  # Correct - exact match
elif self._backend == "tokenizers":  # Correct - exact match

Impact

• Behavior: No functional change for current backend names
• Robustness: Prevents future bugs if backend names change
• Consistency: Aligns with all other backend checks in the codebase

Testing

• Existing tests should pass (no behavior change)
• The fix ensures exact string matching as intended

Files Changed

• src/chonkie/tokenizer.py: Lines 651-653 in decode_batch method

This is a small but important fix to prevent potential future issues with tokenizer routing.

[gemini-code-assist]

Summary of Changes

Hello @anaslimem, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability of the tokenizer's backend selection process. By transitioning from substring-based comparisons to exact string matching, the change fortifies the system against potential future inconsistencies in backend naming, ensuring that the correct tokenizer implementation is always invoked. This is a preventative measure to improve code robustness and maintainability.

Highlights

• Backend Check Logic Refinement: The decode_batch method in src/chonkie/tokenizer.py has been updated to use strict equality (==) instead of substring matching (in) for tiktoken and tokenizers backend checks. This change ensures precise backend identification and prevents potential misrouting if backend names were to change or be extended in the future.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/chonkie/tokenizer.py
  • Modified the decode_batch method to replace in with == for tiktoken backend comparison.
  • Modified the decode_batch method to replace in with == for tokenizers backend comparison.

Activity

• No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in decode_batch where backend checks were using substring matching (in) instead of strict equality (==). This change improves the robustness and consistency of the code. I've also suggested a small refactoring in the same method to reduce code duplication by grouping backends that share the same implementation.