test: add tests for custom task id#134
Merged
ripienaar merged 2 commits intochoria-io:mainfrom May 27, 2025
Merged
Conversation
Member
|
I think |
ripienaar
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for #131
The second test fail, if the provided ID has invalid characters, disallowed by NATS subject restrictions. Not sure, if you want to check the validity of ID, if it is provided by the library user. If that is the case, I can remove the 2nd test, and use
IsValidNamein theCustomIDGeneratorin the first test to show the intent that it is the responsibility of the user to check for the validity of the ID.