feat: add import/export functionality to the game screen#40
Open
oneeyedman wants to merge 1 commit intochr15m:masterfrom
Open
feat: add import/export functionality to the game screen#40oneeyedman wants to merge 1 commit intochr15m:masterfrom
oneeyedman wants to merge 1 commit intochr15m:masterfrom
Conversation
Owner
|
This is super cool, thanks for sending it through. I really like the simple design you came up with. I will probably do an implementation in ClojureScript at some point but I will leave this PR here for reference. Thank you very much for taking a crack at it! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi, @chr15m:
I made the importer/exporter development, and though it works I don't properly know Clojure, so I found a way to copy the JS file with the functionality to the public folder, and I'm sure it's
further than rightinsufficient or incorrect..For the importer/exporter system to work, you need to follow these steps.
On your browser:
On the new browser:
I made a basic design, trying to match the game's looks.
Game page with the new buttons:

Game page warning modal:

Please look at the code, knowing that I've tried my best. Please keep what you like, ask for improvements or changes as you see fit, and if you change your mind or simply discover that you don't like the PR, please know that it is completely okay with me.
Close #39