Form flow fixes, minor Codacy fixes

#1884 This is the first commit after activating the todo bot, so standby for potentially up to 70+ new automated issues...

Author: chrisblakley

Nebula-Child/resources/sw.js

@@ -1,6 +1,6 @@
 //BEGIN automated edits. These will be automatically overwritten.
 var THEME_NAME = 'nebula-child';
-var NEBULA_VERSION = 'v6.12.1.5244'; //Wednesday, May 1, 2019 10:57:42 PM
+var NEBULA_VERSION = 'v6.12.2.4804'; //Thursday, May 2, 2019 11:32:09 AM
 var OFFLINE_URL = 'https://gearside.com/nebula/offline/';
 var OFFLINE_IMG = 'https://gearside.com/nebula/wp-content/themes/Nebula-master/assets/img/offline.svg';
 var OFFLINE_GA_DIMENSION = 'cd2';

Nebula-Child/style.css

@@ -2209,7 +2209,7 @@ function cf7Functions(){
 			event: e,
 			category: 'CF7 Form',
 			action: 'Submit (Invalid)',
-			formID: e.detail.contactFormId || e.detail.id,
+			formID: e.detail.id,
 			formTime: nebulaTimer(e.detail.id, 'lap', 'wpcf7-submit-invalid'),
 			inputs: nebula.timings[e.detail.id].laps + ' inputs'
 		}
@@ -2254,7 +2254,7 @@ function cf7Functions(){
 			event: e,
 			category: 'CF7 Form',
 			action: 'Submit (Invalid)',
-			formID: e.detail.contactFormId || e.detail.id,
+			formID: e.detail.id,
 			formTime: nebulaTimer(e.detail.id, 'end'),
 			inputs: nebula.timings[e.detail.id].laps + ' inputs'
 		}
@@ -2277,7 +2277,7 @@ function cf7Functions(){
 			event: e,
 			category: 'CF7 Form',
 			action: 'Submit (Failed)',
-			formID: e.detail.contactFormId || e.detail.id,
+			formID: e.detail.id,
 			formTime: nebulaTimer(e.detail.id, 'end'),
 			inputs: nebula.timings[e.detail.id].laps + ' inputs'
 		}
@@ -2302,7 +2302,7 @@ function cf7Functions(){
 			event: e,
 			category: 'CF7 Form',
 			action: 'Submit (Success)',
-			formID: e.detail.contactFormId || e.detail.id,
+			formID: e.detail.id,
 			formTime: nebulaTimer(e.detail.id, 'end'),
 			inputs: nebula.timings[e.detail.id].laps + ' inputs'
 		}
@@ -2337,7 +2337,7 @@ function cf7Functions(){
 			event: e,
 			category: 'CF7 Form',
 			action: 'Submit (Attempt)',
-			formID: e.detail.contactFormId || e.detail.id,
+			formID: e.detail.id,
 			formTime: nebulaTimer(e.detail.id, 'lap', 'wpcf7-submit-attempt'),
 			inputs: nebula.timings[e.detail.id].laps + ' inputs'
 		}
@@ -3270,10 +3270,13 @@ function svgImgs(){
 				var theSVG = jQuery(data).find('svg'); //Get the SVG tag, ignore the rest
 				theSVG = theSVG.attr('id', oThis.attr('id')); //Add replaced image's ID to the new SVG
 				theSVG = theSVG.attr('class', oThis.attr('class') + ' replaced-svg'); //Add replaced image's classes to the new SVG
+				theSVG = theSVG.attr('role', 'img');
 				theSVG = theSVG.attr('data-original-src', oThis.attr('src')); //Add an attribute of the original SVG location
 				theSVG = theSVG.removeAttr('xmlns:a'); //Remove invalid XML tags
 				oThis.replaceWith(theSVG); //Replace image with new SVG
 			}, 'xml');
+
+			//@todo "Nebula" 0: Grab the alt attribute from oThis and add it as a <title> tag within the newly created <svg> element (as the first child)
 		}
 	});
 }

assets/css/admin.css

@@ -76,14 +76,14 @@
 				classes: 'widget btn nebula-icon',
 				menu: [{
 					text: 'Container',
-					onclick: function() {
+					onclick: function(){
 						ed.focus();
 						var shortcodeContent = ( tinyMCE.activeEditor.selection.getContent() !== '' )? tinyMCE.activeEditor.selection.getContent() : 'CONTENT_HERE';
 						ed.selection.setContent('[container class="CLASSES" style="STYLES"]' + shortcodeContent + '[/container]');
 					}
 				}, {
 					text: 'Row',
-					onclick: function() {
+					onclick: function(){
 						ed.focus();
 						var shortcodeContent = ( tinyMCE.activeEditor.selection.getContent() !== '' )? tinyMCE.activeEditor.selection.getContent() : 'CONTENT_HERE';
 						ed.selection.setContent('[row class="CLASSES" style="STYLES"]' + shortcodeContent + '[/row]');

assets/css/critical.css

@@ -4,7 +4,7 @@
 	Description: Nebula is a springboard WordPress theme framework for developers. Like other WordPress startup themes, it has custom functionality built-in (like shortcodes, styles, and JS/PHP functions), but unlike other themes Nebula is not meant for the end-user.
 	Author: Pinckney Hugo Group
 	Author URI: http://www.pinckneyhugo.com
-	Version: 6.12.1.9568
+	Version: 6.12.2.4808
 	License: GNU General Public License v2.0 or later
 	License URI: http://www.gnu.org/licenses/gpl-2.0.html
 	Tags: one-column, two-columns, three-columns, four-columns, left-sidebar, right-sidebar, threaded-comments, theme-options, sticky-post, post-formats, microformats, full-width-template, front-page-post-form, flexible-header, featured-images, featured-image-header, editor-style, custom-menu, custom-colors, accessibility-ready

assets/css/login.css

@@ -1,5 +1,5 @@
 {
-	"version": "6.12.1.9568",
+	"version": "6.12.2.4808",
 	"details_url": "https://github.com/chrisblakley/Nebula/commits/master",
 	"download_url": "https://github.com/chrisblakley/Nebula/archive/master.zip"
 }