Generated relation types are now shallow, BREAKING CHANGE #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, fields in a <Model>Relations type would reference <OtherModel>Relations type, which would often reference <Model>Relations type itself, leading to infinite nesting. Now instead the fields reference <OtherModel>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a reference on how #304 could be solved. One could also add a new type
<Model>ShallowRelations, but it would be more work to add this to all the conditionals, so I wanted to get your opinion on it first @chrishoermann. As described in the issue, I don't fully see how non-shallow relations would be actually useful.Before this, fields in a Relations type would reference Relations type, which would often reference Relations type itself, leading to infinite nesting.
Now instead the fields reference