Skip to content

Feat/manage tile alloc#1505

Open
Mico27 wants to merge 4 commits intochrismaltby:developfrom
Mico27:feat/manage_tile_alloc
Open

Feat/manage tile alloc#1505
Mico27 wants to merge 4 commits intochrismaltby:developfrom
Mico27:feat/manage_tile_alloc

Conversation

@Mico27
Copy link
Contributor

@Mico27 Mico27 commented Aug 13, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature: Allows the user to specify the tile allocation style for a background.

By default both options are checked and is the same behaviour as GBS 4 which reserve tiles for its default ui and allocate BG tiles upwards in the shared tileset VRAM to prioritise sprite tile overflowing in it.

Unchecking both options "Prioritize Sprite Allocation" and "Reserve UI Tiles" will have the same behaviour as GBS 3.

  • What is the current behavior? (You can also link to an open issue here)
    Current behavior forces a certain tile allocation, making it hard to have control over the tileset VRAM

  • What is the new behavior (if this is a feature change)?
    2 checkboxes are added under the background selection in a scene allowing to change tile allocation behavior.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No breaking changes should occur as the tile allocation will be the same as GBS 4 was by default.

  • Other information:
    Some screenshots
    image
    image

Mico27 added 4 commits August 12, 2024 21:39
For people who have some scenes that have more than 192 unique tiles (up to 256 in normal mode and up to 512 in color-only mode) and dont use the default ui system.
issues fixed:
- The background image compiler would cap at 192 unique tile, not allowing any way to have more tiles even with a plugin fix
- Removed ALLOC_BKG_TILES_TOWARDS_SPR definition in the engine as the new allocation hard caps at 192 tiles
…ackground.

By default its the same behaviour as GBS 4 which reserve tiles for its default ui and allocate BG tiles upwards in the shared tileset VRAM to prioritise sprite tile overflowing in it.

Unchecking both options "Prioritize Sprite Allocation" and "Reserve UI Tiles" will have the same behaviour as GBS 3.
# Conflicts:
#	src/lib/compiler/compileImages.ts
@maxoakland
Copy link

I love this idea. Having more control over tile management would enable a lot of clever trickery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants