remove the exception message, and use report#69
remove the exception message, and use report#69atmonshi wants to merge 1 commit intochrisreedio:3.xfrom
Conversation
|
Thanks for your PR @atmonshi ! Perhaps we can tweak what data is in the exception message? The thought was that if the developer needed to handle any extra cases in which the login would be aborted they could use the exception message to have it shown in the error message. Sorry if I disappear out of the blue, my wife is due to go into labor any day so I may be out of pocket at a moments notice. |
|
hey Chris, no worries. and congrats, that's so exciting! wishing you both a smooth and safe delivery. |
@atmonshi We had a great delivery but time slips away faster now than ever. Did you ever take another look at this? Absolutely no rush just saw the PR and reminded me to check in. |
hey Chris, so I got this error as you can see the message contain kinda sensitive info about the database when the expiation
AbortedLoginExceptionthrown.so I replaced that with
Login abortedinstead of$e->getMessage()the other thing that I didn't get an exception alert on sentry (or any other error reporting tools) coz the exception been handled by (try/catch), so I added
report($e);.