-
Notifications
You must be signed in to change notification settings - Fork 0
added transition #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Christ,
Hierbij mijn review van je code. Het ziet er goed uit en heb een paar kleine opmerkingen, maar ik denk dat je die zelf ook wel doorhad.
groet,
Stephan
|
||
#container { | ||
background-color: white; | ||
border: aqua 10px solid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christdoesselaere: de border van "container" is nog zichtbaar.
--menu-bar-height: 10px; | ||
} | ||
|
||
#container { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christdoesselaere:
Het activatie-kader lijkt nu wat groot: het was de bedoeling om de transitie aan te roepen bij het hoveren over een van de drie balkjes.
In de antwoorden wordt er een width gespecificeerd: width: var(--menu-bar-width), die ontbreekt nog in jouw oplossing;
} | ||
|
||
#container:hover #menu::before { | ||
transform: translateY(20px) rotate(45deg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christdoesselaere: de top parameter van "#container:hover #menu::before " is niet gespecificeerd (zou top: 0;) moeten zijn, maar zie dat je het hebt opgelost in de transform-waarde translateY.
top: 20px; | ||
} | ||
|
||
:root { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christdoesselaere: Overzichtelijk geschreven code, makkelijk te reviewen!
} | ||
|
||
#container:hover #menu::after { | ||
transform: translateY(-20px) rotate(-45deg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christdoesselaere: de top parameter van "#container:hover #menu::before " is niet gespecificeerd (zou top: 0;) moeten zijn, maar zie dat je het hebt opgelost in de transform-waarde translateY.
#menu, | ||
#menu::before, | ||
#menu::after { | ||
transition: all .2s ease-in-out; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christdoesselaere: goede oplossing! Die ga ik van je overnemen
Graag wijzigingen controleren