Skip to content

Replace deprecated setup.py develop command with pip install -e#64

Closed
Copilot wants to merge 5 commits intomainfrom
copilot/fix-59-2
Closed

Replace deprecated setup.py develop command with pip install -e#64
Copilot wants to merge 5 commits intomainfrom
copilot/fix-59-2

Conversation

Copy link
Contributor

Copilot AI commented May 21, 2025

This PR addresses the deprecation warning from using python setup.py develop command. As mentioned in the warning message, this command is scheduled for removal by October 31, 2025.

Changes

  • Modified the Makefile to replace python setup.py develop with pip install --no-build-isolation -e .
  • Added the --no-build-isolation flag to avoid potential network issues when fetching dependencies from PyPI
  • All tests continue to run successfully after this change

This change ensures that the package can be developed without the deprecated setup.py develop command, using the recommended standards-based tools (pip) instead.

Note: There's still a similar deprecation warning for the python setup.py sdist bdist_wheel command in the package target, but that could be addressed in a separate PR to maintain minimal changes.

Fixes #59.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: christianhelle <710400+christianhelle@users.noreply.github.com>
Copilot AI changed the title [WIP] Avoid running setup.py and develop Replace deprecated setup.py develop command with pip install -e May 21, 2025
Copilot AI requested a review from christianhelle May 21, 2025 23:05
@christianhelle
Copy link
Owner

@copilot setup.py develop is still used in .github/workflows/build-for-os.yml. Fix it

Co-authored-by: christianhelle <710400+christianhelle@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented May 22, 2025

@copilot setup.py develop is still used in .github/workflows/build-for-os.yml. Fix it

I've fixed the deprecated setup.py develop command in .github/workflows/build-for-os.yml by replacing it with pip install --no-build-isolation -e ., consistent with the previous change to the Makefile. See commit 6b29429.

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.07%. Comparing base (ca7025f) to head (faaf5bc).
⚠️ Report is 62 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          48       48           
  Lines        2808     2808           
=======================================
  Hits         2754     2754           
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christianhelle
Copy link
Owner

@copilot This approach fails for Python versions older than version 3.12. Update the build workflows that use Python versions older than 3.12 to use setup.py develop

Co-authored-by: christianhelle <710400+christianhelle@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented May 24, 2025

@copilot This approach fails for Python versions older than version 3.12. Update the build workflows that use Python versions older than 3.12 to use setup.py develop

I've updated the workflow file to handle Python version compatibility as requested. Now it will:

  • Use python setup.py develop for Python versions < 3.12
  • Use pip install --no-build-isolation -e . for Python versions >= 3.12

See commit b3723a0.

@christianhelle
Copy link
Owner

@copilot the build still fails for Python v3.8 and v3.9

Co-authored-by: christianhelle <710400+christianhelle@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented May 27, 2025

@copilot the build still fails for Python v3.8 and v3.9

I've modified the workflow file to use a different approach for Python version detection. Now it will:

  • Use exact string comparison instead of version comparison operators
  • Use python setup.py develop specifically for Python 3.8 and 3.9
  • Use pip install --no-build-isolation -e . for Python 3.10 and above

See commit faaf5bc.

@sonarqubecloud
Copy link

@christianhelle
Copy link
Owner

Superseded by Deckard's migration to pyproject.toml (issue #59). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid running setup.py and develop

2 participants