Revert breaking OpenAPI v3.x upgrades and fix Spectre.Console.Cli signature#287
Revert breaking OpenAPI v3.x upgrades and fix Spectre.Console.Cli signature#287christianhelle merged 2 commits intomainfrom
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
…change Co-authored-by: christianhelle <710400+christianhelle@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 84.93% 84.93%
=======================================
Files 12 12
Lines 551 551
Branches 76 76
=======================================
Hits 468 468
Misses 70 70
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR reverts incompatible OpenAPI v3.x package upgrades that caused build failures and fixes the method signature to comply with Spectre.Console.Cli 0.53.0 requirements.
- Downgrades Microsoft.OpenApi packages from v3.x to v1.6.x to restore compatibility with the existing dependency chain
- Updates
GenerateCommand.ExecuteAsyncsignature to include the requiredCancellationTokenparameter - Maintains backward compatibility with existing tests through the use of a default parameter value
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/HttpGenerator/HttpGenerator.csproj | Reverts Microsoft.OpenApi.OData from 3.0.0 to 1.7.5 for compatibility with OpenApi 1.6.28 |
| src/HttpGenerator.Core/HttpGenerator.Core.csproj | Reverts Microsoft.OpenApi from 3.0.1 to 1.6.28 to match Microsoft.OpenApi.Readers version |
| src/HttpGenerator/GenerateCommand.cs | Adds required CancellationToken parameter with default value to satisfy Spectre.Console.Cli 0.53.0 signature requirements |
Comments suppressed due to low confidence (1)
src/HttpGenerator/GenerateCommand.cs:264
- This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.
foreach (var file in files)
{
var fullPath = Path.Combine(outputFolder, file.Filename);
AnsiConsole.MarkupLine($" [dim]📄[/] [link]{fullPath}[/]");
}




Recent dependency upgrades introduced incompatible breaking changes causing build failures across all workflows.
Changes
Revert Microsoft.OpenApi: 3.0.1 → 1.6.28 in
HttpGenerator.Core.csprojMicrosoft.OpenApi.Readers1.6.28 which depends on 1.6.28Revert Microsoft.OpenApi.OData: 3.0.0 → 1.7.5 in
HttpGenerator.csprojFix Spectre.Console.Cli signature: Add
CancellationTokenparameter toGenerateCommand.ExecuteAsyncAsyncCommand<T>.ExecuteAsyncsignatureContext
PR #282 attempted to upgrade to OpenAPI.NET v3 for OpenAPI 3.2.0 support, but this requires coordinated upgrades across the entire dependency chain. The Microsoft.OpenApi v3.x series has breaking changes that are incompatible with the current
Microsoft.OpenApi.Readersversion.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
demo.netbox.dev/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/HttpGenerator.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/HttpGenerator.Tests.deps.json /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/testhost.dll --port 40847 --endpoint 127.0.0.1:040847 --role client --parentprocessid 4054 --telemetryoptedin false(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/HttpGenerator.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/HttpGenerator.Tests.deps.json /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/testhost.dll --port 38055 --endpoint 127.0.0.1:038055 --role client --parentprocessid 5019 --telemetryoptedin false(dns block)developers.intellihr.io/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/HttpGenerator.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/HttpGenerator.Tests.deps.json /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/testhost.dll --port 40847 --endpoint 127.0.0.1:040847 --role client --parentprocessid 4054 --telemetryoptedin false(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/HttpGenerator.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/HttpGenerator.Tests.deps.json /home/REDACTED/work/httpgenerator/httpgenerator/src/HttpGenerator.Tests/bin/Release/net8.0/testhost.dll --port 38055 --endpoint 127.0.0.1:038055 --role client --parentprocessid 5019 --telemetryoptedin false(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.