refactor(types): deduplicate QueryEmbeddingState and Source twins - #152
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
christopherkarani
added
the
ready-for-review
christopherkarani
added a commit
that referenced
this pull request
Aug 25, 2026
christopherkarani
added a commit
that referenced
this pull request
Aug 25, 2026
…#151) * refactor(types): unify retrieval-mode twins into canonical SearchMode * review(t1): document canonical public SearchMode and fix stale bare RetrievalMode prose * review(t1-final): align CONTEXT.md glossary with canonical SearchMode * refactor(types): deduplicate QueryEmbeddingState and Source twins (#152)
christopherkarani
added a commit
that referenced
this pull request
Aug 31, 2026
…#151) * refactor(types): unify retrieval-mode twins into canonical SearchMode * review(t1): document canonical public SearchMode and fix stale bare RetrievalMode prose * review(t1-final): align CONTEXT.md glossary with canonical SearchMode * refactor(types): deduplicate QueryEmbeddingState and Source twins (#152)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket T2 — functional-evolution spec (candidate 01b). Stacked on #151.
Spec: /var/folders/ns/xmz0zmpj7p148vdgr4bwzp8h0000gn/T/swift-arch-0b27937a/spec/spec-architecture-functional-evolution.md
What
One declaration each:
RAGContext.QueryEmbeddingState(public twin kept; package copy in MemoryOrchestrator deleted, raw values byte-stable) andRAGContext.Source(SearchResponse.Sourceis now a typealias; converter pair deleted;CaseIterabledropped as dead surface — zero allCases/(rawValue:) uses). Empty-sources[.unknown]defaulting inlined at 3 FastRAGContextBuilder sites. Net −55 lines.Wire-format note (CON-004 ruled by reviewer)
Structured-lane emitted source label changes
"structuredMemory"→"structured". Ruled ACCEPT with evidence: the only parse-back site (LayeredRecall.ragSources(from:)) never accepted the old string — it silently dropped structured labels to.unknown; rename repairs that latent loss. Zero consumers/docs/hermes/npm pin the old label; decode side untouched.Review
Implementer: fresh subagent (
3d3a7f99b) · Review 1: swift-adversarial-pr-review → APPROVE, no fixes · Final pass: second fresh adversarial reviewer → APPROVE, all 6 prior claims independently verified, no fixes.Verification
UnifiedSearchTests 38✓ · WaxPublicDocsTests 4✓ · DocsPasteHarnessTests 9✓ · BrokerCommandDecodeTests 23✓ · MemoryOrchestratorTests 16✓×2 · builds green under MiniLMEmbeddings + MCPServer traits.