refactor(broker): close horizon lane selection behind HorizonSet - #156
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
christopherkarani
added
the
ready-for-review
christopherkarani
added a commit
that referenced
this pull request
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: spec/spec-architecture-type-system-hardening.md (ticket T1)
What
Replaces the includeWorking/includeEpisodic/includeDurable Bool×3 threading across BrokerCommand -> AgentBrokerService -> LayeredRecall.SearchRequest with a package-internal
HorizonSetOptionSet over the existing Horizon lanes.Compiler gain
An empty lane selection no longer compiles through: decode rejects it with a named error mentioning lanes (previously it silently searched nothing). The hand-written scope override table collapses into pure set algebra pinned by an exhaustive 24-cell test against the old behavior.
Wire compatibility
Wire keys include_working/include_episodic/include_durable unchanged, defaults unchanged (absent = all lanes). Only behavior delta: all-false requests now fail decode instead of returning empty results.
Verification
Targeted suites green: HorizonScopeSelectionTests 4/4, BrokerCommandDecodeTests 25/25, LayeredRecallTests 37/37 combined run, brokerMemorySearch end-to-end 4/4. Two WaxMCPServerTests source-scanner failures proven pre-existing at base 572b786.
Review skills used: swift-adversarial-pr-review x2 (fresh-context fix-allowed review + independent final pass, both APPROVE, zero code findings).