refactor(types): close frame-kind vocabulary behind FrameKind - #157
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
christopherkarani
added
the
ready-for-review
christopherkarani
added a commit
that referenced
this pull request
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: spec/spec-architecture-type-system-hardening.md (ticket T4)
What
Closes the FrameMeta.kind String vocabulary behind package enum
FrameKind(Wax module): cases surrogate/handoff, nested photo(VideoFrameKind)/video rawValues, and .other(String) forward-compat passthrough. Storage stays String? on disk - bytes identical.Compiler gain
All kind comparison sites (PhotoRAG x5, VideoRAG x2, UnifiedSearch x2, MemoryOrchestrator/maintenance) parse once through FrameKind; typo'd literals stop compiling and the exhaustiveness-critical switch is default-free (adding a case breaks compilation, verified live). Unknown stored kinds survive re-save via .other.
Writer survey
Every value ever written: surrogate, handoff, enrichment, wax.internal.access_stats (left as centralized constant crossing the WaxCore API), note (CLI demo), photo.* x7 rawValues, video.root/video.segment. All round-trip byte-identically per characterization test.
Verification
FrameKindTests 4/4; PhotoRAG|VideoRAG|UnifiedSearch 94/95 with the single failure (videoRAGRecallBreaksEqualScoreTiesByRootID float tie) proven pre-existing at base. Scope: exactly 7 ticket files; WaxCore untouched; no public API changes.
Review skills used: swift-adversarial-pr-review x2 (fresh-context fix-allowed review + independent final pass, both APPROVE, zero fixes required).