Fix memory overflow if WriteString exceed memory capacity#36
Open
ben-page wants to merge 2 commits intochristophwille:masterfrom
Open
Fix memory overflow if WriteString exceed memory capacity#36ben-page wants to merge 2 commits intochristophwille:masterfrom
ben-page wants to merge 2 commits intochristophwille:masterfrom
Conversation
Owner
|
this library mimics what npm-opa-wasm does in terms of execution order. |
Author
I can take out the first commit, if that helps. It's a small amount of wasted memory. The second commit is the important one. |
Owner
|
Yes (and I just saw that npm-opa-wasm has applied memory fixes recently, so I'll have to take a look at their recent history too) Edit: opened #38 for mem fix note above. |
Owner
|
Can we somehow unit test the behavior? |
Author
I think so. Give a me a couple days. |
Owner
|
open-policy-agent/npm-opa-wasm@f1be838 corresponding JS impl |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FastEvaluate()is called when_dataHeapPtris near the end of the memory store, it can overflow the store. I created a method to check the memory capacity and grow as necessary.