Skip to content

Push notifications#762

Open
afonsomota wants to merge 14 commits intochrisvel:mainfrom
afonsomota:feat-push-notifications
Open

Push notifications#762
afonsomota wants to merge 14 commits intochrisvel:mainfrom
afonsomota:feat-push-notifications

Conversation

@afonsomota
Copy link
Copy Markdown

@afonsomota afonsomota commented Jan 6, 2026

Description

This PR sets up a PWA service worker and implements push notifications as a mobile/desktop app.

Type of Change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Breaking change (breaks existing functionality)
  • Documentation/Translation update

Related Issues

Implementation suggestion for discussion #228

Fixes #

Testing

How did you test this?
Some backend code tests regarding the push notification subscription and unsubscription. Also manually tested in MacOS and iOS the push functionality,

Commands run:

  • npm run pre-push (linting + formatting + tests)
  • Tested manually in browser
  • Tested on mobile (if UI changes)

Screenshots

image

Checklist

  • This is not an AI slop crap, I know what I am doing
  • Code follows project style guidelines
  • Self-reviewed my own code
  • Added/updated tests (if applicable)
  • Updated documentation (if needed)
  • Database migrations included and tested (if applicable)
  • Translation keys added and synced (if applicable)

@afonsomota
Copy link
Copy Markdown
Author

Two things for discussion:

  • I tried to make the app workable offline (PWA), but did not had time to complete that. There is a lot of code on cache, offline page and the SW is dynamically change to get the proper name for main.js. I can remove this to make the PR cleaner, but it should be simpler to start from here if I or someone goes for offline support in the future.

  • There is a test notification functionality. Thought it was handy to stay since there is a lot of issues regarding app notification authorization in the OS. I used it for testing, but left it. We can hide it or remove it if you want.

@afonsomota
Copy link
Copy Markdown
Author

Merged with main and did the necessary changes from routes to modules. Tests passed locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant