-
Notifications
You must be signed in to change notification settings - Fork 18
Added option to suppress default title and fixed some tabbing #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@cjfman If you're still out there, I'd like to rebase your commits for you against the current master and then start a new pull request to get this merged in. Is that OK with you? |
|
Hello,
Yes please, pull it in.
…On Wed, Aug 5, 2020 at 9:51 PM Kevin Ernst ***@***.***> wrote:
@cjfman <https://github.com/cjfman> If you're still out there, I'd like
to rebase your commits for you against the current master and then start a
new pull request to get this merged in.
Is that OK with you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYSBHYIZ4YS5Q2D2KIMTFDR7IEBBANCNFSM4EOSY63A>
.
|
|
Ok, @ernstki, I've finished the rebase. Ready to merge. |
|
Super, thanks. I didn't expect that! I'm having a look to see if I can make the Is that something you would be willing to integrate into your PR if I do most of the legwork for you (e.g., provide a patch)? |
|
Yeah, that's fine. Teamwork!
~Charles
…On Fri, Aug 7, 2020 at 12:44 PM Kevin Ernst ***@***.***> wrote:
Super, thanks. I didn't expect that!
I'm having a look to see if I can make the --notitle option work with the
-m / --mulfrmul (multiple curves from multiple files). I feel strongly
about "truth in advertising," so --notitle should do what it says, for
single *and* multiple plots.
Is that something you would be willing to integrate into your PR if I do
most of the legwork for you (*e.g.*, provide a patch)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYSBH6OTGFHZ3VSMSRYKWLR7QVNLANCNFSM4EOSY63A>
.
|
|
Just to clarify, yes please provide the patch. |
|
If you've never dealt with a patch file (likely you have, but I don't want to assume), this should work: cd /place/where/you/cloned/eplot
curl https://github.com/cjfman/eplot/compare/master...ernstki:add-notitle-option.diff \
| patch -p1I only added one line of code to get I thought a PR for a PR would be way overengineering it, but if that's actually easier for you somehow, I can. |
|
@ernstki, Thanks for the quick patch command. I've used patches before, but they trip me up every time. Everything should be ready to go. |
|
@cjfman You have to actually look at the first line of the patch file to figure out what number to give to So in this example, if I wanted to apply the patch file below to an diff --git a/eplot b/eplot
index 9337375..c93d678 100755
--- a/eplot
+++ b/eplotIn the confines of GitHub, you can add You can make your own patch file in the same "unified" format with Hope that helps! |
|
@chriswolfvision Does this look OK to merge in? I have tests in another branch in my personal fork, if you want some assurances that it works as advertised. |
|
@chriswolfvision looks good to me! |
No description provided.