Conversation
|
@chrmarti If this PR is approved and you're ok with it, can you please add the |
|
Hope this PR can be approved soon. |
|
This PR has been sitting for ~6 months now, any chance of merging it, or is development on this extension stopped? |
|
This PR has been sitting for about a year now. Any chance it will be approved? Or is this extension abandoned? |
|
@anthonyjvoss Sorry for the delay, could you add Python to the package.json's description and activation events? Thanks! |
Update the package.json file to include Python in the package description as well as the activationEvents array.
|
@chrmarti - I have updated the package.json and pushed the updates to this branch. Thank you for the response. |
|
A speedy release would be very happy :) |
| const regexRegex = /(^|\s|[()={},:?;])(\/((?:\\\/|\[[^\]]*\]|[^/])+)\/([gimuy]*))(\s|[()={},:?;]|$)/g; | ||
| const phpRegexRegex = /(^|\s|[()={},:?;])['|"](\/((?:\\\/|\[[^\]]*\]|[^/])+)\/([gimuy]*))['|"](\s|[()={},:?;]|$)/g; | ||
| const haxeRegexRegex = /(^|\s|[()={},:?;])(~\/((?:\\\/|\[[^\]]*\]|[^/])+)\/([gimsu]*))(\s|[.()={},:?;]|$)/g; | ||
| const pyRegexRegex = /(^|\s|[()={},:?;])['|"](((?:\\\/|\[[^\]]*\]|[^/])+)([gimuy]*))['|"](\s|[()={},:?;]|$)/g; |
There was a problem hiding this comment.
I realize this shows the code lens above all strings. That seems a bit too much. Is there a way to reduce this to only match actual regular expressions? E.g., by only matching on strings as parameters to re.search and others?
There was a problem hiding this comment.
Can you provide a little more detail around what you're seeing and potential drawbacks? This should be providing the same match/highlighting as the other languages.
There was a problem hiding this comment.
It seems to match strings that are not used as regular expressions. E.g.:
Since strings are very common this would add a 'Test Regex...' link in many places where it doesn't actually makes sense. (Maybe you disabled code lenses and don't see that.)
There was a problem hiding this comment.
| const pyRegexRegex = /(^|\s|[()={},:?;])['|"](((?:\\\/|\[[^\]]*\]|[^/])+)([gimuy]*))['|"](\s|[()={},:?;]|$)/g; | |
| const pyRegexRegex = /(^|\s|[()={},:?;])r['|"](((?:\\\/|\[[^\]]*\]|[^/])+)([gimuy]*))['|"](\s|[()={},:?;]|$)/g; |
Would it be acceptable to change the regex to only match "raw" strings (e.g r"\d{4}-\d{2}")? Sure it's not a perfect solution, as we would miss some simple regexes and also have a bunch of false positives, but if a caveat is added in the doc, it could work.
|
@anthonyjvoss can you fix this? |
|
Any update on getting this PR pushed through? @anthonyjvoss @chrmarti |
9 participants
Provide users the ability to use the extension with Python files.
Closes #35