[BLD]: switch to Maturin for build, bundle Rust code with package#3766
Merged
codetheweb merged 35 commits intomainfrom Feb 18, 2025
Merged
[BLD]: switch to Maturin for build, bundle Rust code with package#3766codetheweb merged 35 commits intomainfrom
codetheweb merged 35 commits intomainfrom
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
a73207f to
761814e
Compare
a95775c to
6a84ffa
Compare
236b7de to
3315c14
Compare
f5838fd to
8440b6f
Compare
8440b6f to
151cde6
Compare
25b3791 to
05f0159
Compare
05f0159 to
cb36ac2
Compare
05603d8 to
1467828
Compare
1467828 to
6ac81bc
Compare
codetheweb
commented
Feb 13, 2025
Contributor
Author
There was a problem hiding this comment.
symbolic link, needed for the source distribution to build correctly (otherwise idl/ isn't included)
codetheweb
commented
Feb 13, 2025
codetheweb
commented
Feb 18, 2025
itaismith
approved these changes
Feb 18, 2025
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
…roma-core#3766) ## Description of changes - `maturin` is used to build the main Python package rather than `setuptools` - build & publish to PyPi is its own workflow now and supports manual dispatches - sdist (source distribution) is tested to ensure the artifact has all files required to compile & run the package ## Test plan *How are these changes tested?* Published a test package to test.pypi.org.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
maturinis used to build the main Python package rather thansetuptoolsTest plan
How are these changes tested?
Published a test package to test.pypi.org.