fix: remove duplicate length-consistency check from validate_insert_record_set #5491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length consistency check (
_validate_record_set_length_consistency
) was already performed insidevalidate_base_record_set
, so calling_validate_record_set_length_consistency
insidevalidate_insert_record_set
right before thevalidate_base_record_set
call caused redundant validation.This change removes the duplicate call from
validate_insert_record_set
to avoid unnecessary work, as the function_validate_record_set_length_consistency
does not mutate the global state.