Skip to content

Conversation

tanujnay112
Copy link
Contributor

@tanujnay112 tanujnay112 commented Oct 4, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixed an erroneous NAC rollback guard that was not attached to the request in question.
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the _docs section?_

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Oct 4, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tanujnay112 tanujnay112 marked this pull request as ready for review October 4, 2025 20:56
Copy link
Contributor

Fix Erroneous Priority Rollback Guard in NAC

This pull request addresses a bug in the admissioncontrolleds3.rs file where the RollbackPriorityOnDrop guard was incorrectly attached to a new, statically-constructed InflightRequestContext rather than the actual in-flight request's context. The fix ensures the rollback guard references request.context.clone(), thereby guaranteeing that priority cleanup is performed on the correct, active request when the guard is dropped.

Key Changes

• Modified the assignment of the request field in the RollbackPriorityOnDrop struct initialization within admissioncontrolleds3.rs.
• Changed from a new InflightRequestContext to using request.context.clone() to ensure correct association with the active request.

Affected Areas

• rust/storage/src/admissioncontrolleds3.rs

This summary was automatically generated by @propel-code-bot

@blacksmith-sh blacksmith-sh bot deleted a comment from tanujnay112 Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant