Skip to content

[bugfixes][collection-query] Issue-5857 - Fix mutable default argumen… #5858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[bugfixes][collection-query] Issue-5857 - Fix mutable default argumen… #5858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72cb36f
bugfixes][collection-query] Fixes #5857 - Fix mutable default argumen…
Samyak2406 Nov 13, 2025
433a610
[chore][collection-query] Fixes #5857 - Address pr comments
Samyak2406 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions chromadb/api/models/CollectionCommon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,8 @@ def _validate_and_prepare_get_request(
"You must set a data loader on the collection if loading from URIs."
)

# Prepare
request_include = include
# Copy the list before any in-place modifications.
request_include = list(include) if include else []
# We need to include uris in the result from the API to load datas
if "data" in include and "uris" not in include:
request_include.append("uris")
Expand Down Expand Up @@ -343,7 +343,8 @@ def _validate_and_prepare_query_request(
request_where_document = filters["where_document"]

# We need to manually include uris in the result from the API to load datas
request_include = include
# Copy the list before any in-place modifications.
request_include = list(include) if include else []
if "data" in request_include and "uris" not in request_include:
request_include.append("uris")

Expand Down