Use InvalidArgumentError in ONNX embedding #6402
Open
+9
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ONNX embedding function throws
ValueErrorfor invalid provider inputs,but Chroma's convention is to use
InvalidArgumentErrorfor client-side errors.This creates inconsistent error handling across embedding functions.
Fixes #3026
Changes
ValueErrorwithInvalidArgumentErrorin ONNX provider validationInvalidArgumentErrorimportTesting
Result: 15 passed in 1.97s
Impact