Skip to content

Conversation

@ArivunidhiA
Copy link

@ArivunidhiA ArivunidhiA commented Feb 11, 2026

Problem

The ONNX embedding function throws ValueError for invalid provider inputs,
but Chroma's convention is to use InvalidArgumentError for client-side errors.
This creates inconsistent error handling across embedding functions.

Fixes #3026

Changes

  • Replace ValueError with InvalidArgumentError in ONNX provider validation
  • Add InvalidArgumentError import

Testing

python -m pytest chromadb/test/ef/test_onnx_mini_lm_l6_v2.py -v

Result: 15 passed in 1.97s

Impact

  • Backward compatibility: None - only changes exception type for invalid inputs
  • Breaking changes: None

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

The update spans the entire ONNX MiniLM embedding implementation so that every user-facing validation path now raises InvalidArgumentError, keeping the client API’s error semantics consistent across dependency checks, input verification, and other safeguards.

Affected Areas

chromadb/utils/embedding_functions/onnx_mini_lm_l6_v2.py

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace ValueError/TypeError with InvalidArgumentError

1 participant