Skip to content

[ENH]: Cache rust git submodules in mounted volume#6424

Open
tanujnay112 wants to merge 1 commit intomainfrom
dockerfile_fix
Open

[ENH]: Cache rust git submodules in mounted volume#6424
tanujnay112 wants to merge 1 commit intomainfrom
dockerfile_fix

Conversation

@tanujnay112
Copy link
Contributor

@tanujnay112 tanujnay112 commented Feb 12, 2026

Description of changes

This change speeds up incremental builds by caching git submodules.

  • Improvements & Bug fixes
    • ...
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tanujnay112 tanujnay112 marked this pull request as ready for review February 12, 2026 09:42
@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

Dockerfile now caches Cargo git checkout data

Adds a BuildKit cache mount for the Cargo git directory in rust/Dockerfile, complementing the existing mounts for target and the registry. This allows Rust builds to reuse downloaded git submodules across incremental Docker builds, reducing network traffic and build time.

Key Changes

• Added a new --mount=type=cache,sharing=locked,target=/usr/local/cargo/git/ directive in the RUN layer that performs the workspace build

Possible Issues

• If the directory structure changes in future Rust images, the cache mount may silently fail and provide no benefit.

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants