Add server-side GM visibility control script#5
Merged
Conversation
Nyeriah
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: .Introduce a player script to manage server-side visibility for game masters, ensuring players with
gm visiblecommand can properly use itThis pull request introduces a new player script to enhance server-side visibility handling for Game Masters (GMs). The main change is the addition of logic that automatically upgrades a player's account type to
SEC_GAMEMASTERwhen certain conditions are met, ensuring proper GM visibility permissions.Enhancements to GM visibility logic
mod_gm_commands_playerscriptinsrc/GmCommands.cppthat overridesOnPlayerSetServerSideVisibilityto set a player's account type toSEC_GAMEMASTERwhen they should be visible as a GM and have the appropriate permissions.AddGmCommandScriptsfunction to ensure it is loaded with other GM command scripts.PlayerScript.hheader insrc/GmCommands.cppto support the new player script functionality