Conversation
robot-head
reviewed
Jun 28, 2020
lib/fluent/plugin/in_amqp.rb
Outdated
| cb = Proc.new do | success | | ||
| @ack_queue.push([delivery.delivery_tag, success]) | ||
| end | ||
| payload = { :payload => payload, :callback => cb } |
There was a problem hiding this comment.
confused where the callback is used
Author
There was a problem hiding this comment.
over here: https://github.com/chronicled/fluent-plugin-output-graphql/pull/18
Since we are in the same process should be safe to pass a block (callback) around
obviously this is very implementation specific I would not put this code upstream
Author
|
an additional benefit of this callback mode is it will give us NACKS when HTTP requests fail to hasura. |
tiendatiowa
reviewed
Jun 28, 2020
tiendatiowa
left a comment
tiendatiowa
left a comment
There was a problem hiding this comment.
The code looks ok, but my ruby knowledge is very limited. Maybe Matt can give the final review and approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.