Draft
Conversation
jtmoon79
force-pushed
the
jtmoon79-test_yml_run_publish_package
branch
from
9e75a32 to
fc3e640
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1540 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 37 37
Lines 16662 16662
=======================================
Hits 15656 15656
Misses 1006 1006 ☔ View full report in Codecov by Sentry. |
jtmoon79
force-pushed
the
jtmoon79-test_yml_run_publish_package
branch
5 times, most recently
from
35da889 to
3d60ea0
Compare
jtmoon79
force-pushed
the
jtmoon79-test_yml_run_publish_package
branch
from
3d60ea0 to
aa6a2d5
Compare
Collaborator
|
Thank you! What errors would this catch that our regular build and test CI runs don't catch? |
Collaborator
|
Just added a similar CI job for chrono-tz in chronotope/chrono-tz#158. @jtmoon79 Want to finish up this PR? |
pitdicker
reviewed
Apr 4, 2024
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| - run: cargo publish --locked --dry-run ${{ env.ALL_NON_EXCLUSIVE_FEATURES }} |
Collaborator
There was a problem hiding this comment.
We don't need --locked without a cargo.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that
cargo publishandcargo packagesucceed.