Skip to content

Fix parsing for zone offset seconds#1639

Open
djc wants to merge 1 commit intomainfrom
parse-offset-seconds
Open

Fix parsing for zone offset seconds#1639
djc wants to merge 1 commit intomainfrom
parse-offset-seconds

Conversation

@djc
Copy link
Member

@djc djc commented Dec 11, 2024 •
edited
Loading

%::z is defined as:

Offset from the local time to UTC with seconds.

So it seems like we should support this better?

Fixes #1629.

@djc djc requested a review from pitdicker December 11, 2024 11:13
djc
djc commented Dec 11, 2024
View reviewed changes
src/datetime/tests.rs
assert_eq!(parse("Aug 09 2013 23:54:35 -09 : 00", "%b %d %Y %H:%M:%S %::z"), Ok(dt));
assert_eq!(parse("Aug 09 2013 23:54:35 -09:00:00", "%b %d %Y %H:%M:%S %::z"), Ok(dt));
// mismatching colon expectations
assert!(parse("Aug 09 2013 23:54:35 -09:00:00", "%b %d %Y %H:%M:%S %::z").is_err());
Copy link
Member Author

@djc djc Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems strange that this errored?

Copy link
Collaborator

@pitdicker pitdicker Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are just weird, and I had to fix them endless times during rebases of the branches where I fixed this offset parsing bug.

@djc djc force-pushed the parse-offset-seconds branch from 71b2047 to 7509f42 Compare December 11, 2024 11:14
@djc djc mentioned this pull request Dec 11, 2024
Open
@djc djc force-pushed the parse-offset-seconds branch from 7509f42 to db464fa Compare December 11, 2024 11:16
@codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.90%. Comparing base (8b86349) to head (db464fa).
⚠️ Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
src/format/scan.rs 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1639      +/-   ##
==========================================
- Coverage   91.11%   90.90%   -0.21%     
==========================================
  Files          37       37              
  Lines       17137    17137              
==========================================
- Hits        15614    15579      -35     
- Misses       1523     1558      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pitdicker
Copy link
Collaborator

pitdicker commented Dec 11, 2024

Sorry, I unfortunately don't have time at the moment 😞.

A complete fix with tests for this category of errors is in #1083.

@djc
Copy link
Member Author

djc commented Dec 13, 2024

@pitdicker thanks for the quick response, and the pointer! Going to have a look at your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitdicker pitdicker Awaiting requested review from pitdicker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chrono stftime parsing "%::z" with seconds (+00:00:00)

2 participants

@djc @pitdicker