Bank api inv setup locks#1122
Merged
gmason0 merged 9 commits intochsami:developmentfrom Jun 25, 2025
TheHaliax:BankAPI-InvSetupLocks
Merged
Bank api inv setup locks#1122gmason0 merged 9 commits intochsami:developmentfrom TheHaliax:BankAPI-InvSetupLocks
gmason0 merged 9 commits intochsami:developmentfrom
TheHaliax:BankAPI-InvSetupLocks
Conversation
added slot/item lockstate coverage in Rs2Bank API implemented these changes in InventorySetups with rudimentary auto-sort based on exact setup configuration
gmason0
suggested changes
Jun 23, 2025
Contributor
gmason0
left a comment
gmason0
left a comment
There was a problem hiding this comment.
Can we revert some of the formatting changes that were made here? makes the PR difficult to follow.
gmason0
suggested changes
Jun 24, 2025
Contributor
gmason0
left a comment
gmason0
left a comment
There was a problem hiding this comment.
Great feature - lets just clean up some of the requests here. I also would like to see more of these log messages move to log.debug instead of log.info to avoid spamming the client.log file.
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/Rs2Bank.java
Show resolved
Hide resolved
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/Rs2Bank.java
Outdated
Show resolved
Hide resolved
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/Rs2Bank.java
Show resolved
Hide resolved
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/Rs2Bank.java
Outdated
Show resolved
Hide resolved
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/Rs2Bank.java
Outdated
Show resolved
Hide resolved
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/Rs2Bank.java
Outdated
Show resolved
Hide resolved
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/Rs2Bank.java
Outdated
Show resolved
Hide resolved
Improved inventory setup logic to handle item slot assignments and locking more robustly. Added methods to lock items based on setup, improved detection and toggling of locked slots, and replaced info logs with debug logs for less verbosity. Refactored slot and lock management for better reliability and maintainability.
Added comprehensive Javadoc comments to methods in Rs2InventorySetup and Rs2Bank related to inventory and bank slot locking. These comments clarify method purposes, preconditions, postconditions, and side effects, improving code maintainability and developer understanding. No functional changes were made.
Introduces the toggleLockOnSlot method to toggle the locked state of inventory setup items, update the layout, persist configuration changes, and refresh the UI. Also improves documentation for inventory slot locking logic.
gmason0
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added slot/item lockstate coverage in Rs2Bank API
implemented these changes in InventorySetups with rudimentary auto-sort based on exact setup configuration