Skip to content

fix: remove Applet dependency for non-applet OSRS client #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chsami merged 1 commit into from
Feb 10, 2026
+61 −152
Merged

fix: remove Applet dependency for non-applet OSRS client #1674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions runelite-client/src/main/java/net/runelite/client/RuneLiteDebug.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import net.runelite.api.Client;
import net.runelite.api.Constants;
import net.runelite.client.account.SessionManager;
import net.runelite.client.config.ConfigManager;
import net.runelite.client.discord.DiscordService;
Expand Down Expand Up @@ -71,7 +70,6 @@
import javax.net.ssl.TrustManagerFactory;
import javax.net.ssl.X509TrustManager;
import javax.swing.*;
import java.applet.Applet;
import java.io.File;
import java.io.IOException;
import java.lang.management.ManagementFactory;
Expand Down Expand Up @@ -331,17 +329,18 @@ public void start() throws Exception {
}

setupSystemProps();
// Start the applet

// Start the client
copyJagexCache();
var applet = (Applet) client;
applet.setSize(Constants.GAME_FIXED_SIZE);

System.setProperty("jagex.disableBouncyCastle", "true");
System.setProperty("jagex.userhome", RUNELITE_DIR.getAbsolutePath());

applet.init();
applet.start();
if (isOutdated) {
throw new IllegalStateException("Client failed to load");
}

client.initialize();

SplashScreen.stage(.57, null, "Loading configuration");

Expand Down Expand Up @@ -400,6 +399,8 @@ public void start() throws Exception {

pluginManager.startPlugins();

client.unblockStartup();

if (telemetryClient != null) {
telemetryClient.submitTelemetry();
telemetryClient.submitVmErrors(LOGS_DIR);
Expand Down
5 changes: 2 additions & 3 deletions runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotClientLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,12 @@

import javax.annotation.Nonnull;
import javax.swing.*;
import java.applet.Applet;
import java.io.*;
import java.util.Map;
import java.util.function.Supplier;

@Slf4j
@SuppressWarnings({"deprecation", "removal"})
@SuppressWarnings({"deprecation"})
public class MicrobotClientLoader implements Supplier<Client>
{
private static final int NUM_ATTEMPTS = 6;
Expand Down Expand Up @@ -195,7 +194,7 @@ private Client loadClient(MicrobotRSConfig config) throws ClassNotFoundException
.loadClass(initialClass);

Client rs = (Client) clientClass.newInstance();
((Applet) rs).setStub(new MicrobotRSAppletStub(config, runtimeConfigLoader));
rs.setConfiguration(new MicrobotRSAppletStub(config, runtimeConfigLoader));

log.info("injected-client {}", rs.getBuildID());

Expand Down
191 changes: 50 additions & 141 deletions runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotRSAppletStub.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,42 +26,22 @@
package net.runelite.client.plugins.microbot;

import lombok.RequiredArgsConstructor;
import net.runelite.api.ClientConfiguration;
import net.runelite.client.RuntimeConfig;
import net.runelite.client.RuntimeConfigLoader;
import net.runelite.client.ui.FatalErrorDialog;
import net.runelite.client.util.LinkBrowser;

import javax.swing.*;
import java.applet.Applet;
import java.applet.AppletContext;
import java.applet.AppletStub;
import java.applet.AudioClip;
import java.awt.*;
import java.io.IOException;
import java.io.InputStream;
import java.net.MalformedURLException;
import java.net.URL;
import java.util.Enumeration;
import java.util.Iterator;

@RequiredArgsConstructor
class MicrobotRSAppletStub implements AppletStub
class MicrobotRSAppletStub implements ClientConfiguration
{
private final MicrobotRSConfig config;
private final RuntimeConfigLoader runtimeConfigLoader;

@Override
public boolean isActive()
{
return true;
}

@Override
public URL getDocumentBase()
{
return getCodeBase();
}

@Override
public URL getCodeBase()
{
Expand All @@ -82,129 +62,58 @@ public String getParameter(String name)
}

@Override
public AppletContext getAppletContext()
public void onError(String code)
{
return new AppletContext()
try
{
@Override
public AudioClip getAudioClip(URL url)
{
return null;
}

@Override
public Image getImage(URL url)
{
return null;
}

@Override
public Applet getApplet(String name)
{
return null;
}

@Override
public Enumeration<Applet> getApplets()
{
return null;
}

@Override
public void showDocument(URL url)
{
if (url.getPath().startsWith("/error_game_"))
{
try
{
RuntimeConfig rtc = runtimeConfigLoader.get();
if (rtc.showOutageMessage())
{
return;
}
}
catch (Exception e)
{
}

String code = url.getPath()
.replace("/", "")
.replace(".ws", "");

if (code.equals("error_game_js5connect"))
{
SwingUtilities.invokeLater(() ->
new FatalErrorDialog("RuneLite is unable to connect to the RuneScape update server. " +
"RuneScape might be offline for an update, check the game status page. If the game " +
"is online, then either a firewall is blocking RuneLite, or you don't have internet access.")
.setTitle("RuneLite", "Unable to connect to update server")
.addButton("Game Status", () -> LinkBrowser.browse("https://secure.runescape.com/m=news/game-status-information-centre?oldschool=1"))
.open());
}
else if (code.equals("error_game_js5io"))
{
SwingUtilities.invokeLater(() ->
new FatalErrorDialog("OldSchool RuneScape is unable to retrieve updates from its update server. " +
"This is likely due to a firewall blocking the RuneScape server. Try disabling your firewall, or use " +
"a different network.")
.setTitle("RuneLite", "Unable to connect to update server")
.addHelpButtons()
.open());
}
else if (code.equals("error_game_crash"))
{
SwingUtilities.invokeLater(() ->
new FatalErrorDialog("OldSchool RuneScape has crashed. Crashes are most commonly caused by plugin hub plugins, " +
"but can also be caused by RuneLite or Jagex client bugs. If you receive this message commonly, try playing in " +
"safe mode to eliminate the potential of plugins causing the crash. The client log file will contain additional " +
"information about the crash.")
.setTitle("RuneLite", "OldSchool RuneScape has crashed")
.addHelpButtons()
.open());
}
else
{
SwingUtilities.invokeLater(() ->
new FatalErrorDialog("OldSchool RuneScape has crashed with the message: " + code)
.setTitle("RuneLite", "OldSchool RuneScape has crashed")
.addHelpButtons()
.open());
}
}
}

@Override
public void showDocument(URL url, String target)
RuntimeConfig rtc = runtimeConfigLoader.get();
if (rtc.showOutageMessage())
{
showDocument(url);
return;
}
}
catch (Exception e)
{
}

@Override
public void showStatus(String status)
{
}

@Override
public void setStream(String key, InputStream stream) throws IOException
{
}

@Override
public InputStream getStream(String key)
{
return null;
}

@Override
public Iterator<String> getStreamKeys()
{
return null;
}
};
}

@Override
public void appletResize(int width, int height)
{
if (code.equals("error_game_js5connect"))
{
SwingUtilities.invokeLater(() ->
new FatalErrorDialog("RuneLite is unable to connect to the RuneScape update server. " +
"RuneScape might be offline for an update, check the game status page. If the game " +
"is online, then either a firewall is blocking RuneLite, or you don't have internet access.")
.setTitle("RuneLite", "Unable to connect to update server")
.addButton("Game Status", () -> LinkBrowser.browse("https://secure.runescape.com/m=news/game-status-information-centre?oldschool=1"))
.open());
}
else if (code.equals("error_game_js5io"))
{
SwingUtilities.invokeLater(() ->
new FatalErrorDialog("OldSchool RuneScape is unable to retrieve updates from its update server. " +
"This is likely due to a firewall blocking the RuneScape server. Try disabling your firewall, or use " +
"a different network.")
.setTitle("RuneLite", "Unable to connect to update server")
.addHelpButtons()
.open());
}
else if (code.equals("error_game_crash"))
{
SwingUtilities.invokeLater(() ->
new FatalErrorDialog("OldSchool RuneScape has crashed. Crashes are most commonly caused by plugin hub plugins, " +
"but can also be caused by RuneLite or Jagex client bugs. If you receive this message commonly, try playing in " +
"safe mode to eliminate the potential of plugins causing the crash. The client log file will contain additional " +
"information about the crash.")
.setTitle("RuneLite", "OldSchool RuneScape has crashed")
.addHelpButtons()
.open());
}
else
{
SwingUtilities.invokeLater(() ->
new FatalErrorDialog("OldSchool RuneScape has crashed with the message: " + code)
.setTitle("RuneLite", "OldSchool RuneScape has crashed")
.addHelpButtons()
.open());
}
}
}