[#138] Properly scope path to exe file under temp directory#157
Open
binyomen wants to merge 2 commits intochshersh:mainfrom
Open
[#138] Properly scope path to exe file under temp directory#157binyomen wants to merge 2 commits intochshersh:mainfrom
binyomen wants to merge 2 commits intochshersh:mainfrom
Conversation
A top-level `.exe` file is passed through to `copy_file` without unpacking an archive, which is correct. However, the file was not correctly referred to under the temp directory, meaning we could not find the file to copy.
hdhoang
pushed a commit
to hdhoang/tool-sync
that referenced
this pull request
Mar 8, 2024
hdhoang
pushed a commit
to hdhoang/tool-sync
that referenced
this pull request
Jun 17, 2024
hdhoang
pushed a commit
to hdhoang/tool-sync
that referenced
this pull request
Jun 17, 2024
hdhoang
pushed a commit
to hdhoang/tool-sync
that referenced
this pull request
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A top-level
.exefile is passed through tocopy_filewithout unpacking an archive, which is correct. However, the file was not correctly referred to under the temp directory, meaning we could not find the file to copy.Resolves #138
Additional tasks