[#115] Allow self-updates on Windows#162
Open
FrancisMurillo wants to merge 4 commits intochshersh:mainfrom
Open
[#115] Allow self-updates on Windows#162FrancisMurillo wants to merge 4 commits intochshersh:mainfrom
FrancisMurillo wants to merge 4 commits intochshersh:mainfrom
Conversation
FrancisMurillo
force-pushed
the
feature/self-replace
branch
28 times, most recently
from
7070db9 to
d1b1049
Compare
FrancisMurillo
force-pushed
the
feature/self-replace
branch
10 times, most recently
from
8be045a to
053a513
Compare
FrancisMurillo
force-pushed
the
feature/self-replace
branch
14 times, most recently
from
86f95a6 to
97ac93f
Compare
FrancisMurillo
force-pushed
the
feature/self-replace
branch
from
97ac93f to
ba91e79
Compare
FrancisMurillo
force-pushed
the
feature/self-replace
branch
from
9a55f41 to
734ede8
Compare
Contributor
Author
|
I think the Windows and Unix CI test is sufficient for testing the self-update so I think the PR is ready for review now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow self-updates on Windows by using self-replace crate.
I was able to test this by building a release from Linux to Windows and the self-update works. I would appreciate if somebody else can test this with a dedicated Windows setup since it would take me some time to setup Windows for Rust. Going to add a Windows CI test if I can.
One caveat with
std::env::current_exeis that if the executable is a symbolic link, this may be confused with updating the target of the link or the link itself. Given that the executables are in thestore_directoryand that should be inPATH, the executables should not be a symbolic link so this should not be an issue. Still this may be an edge case.Resolves #115
Additional tasks