Refactor resource pack loading#1734
Merged
leMaik merged 2 commits intochunky-dev:masterfrom Jul 6, 2024
Merged
Conversation
2 tasks
…om a resourcepack. For now, this makes loading painting variant and biome registries less hacky. In the future, this enables loading other files, eg. model json files or PBR maps.
…erageColor static.
leMaik
force-pushed
the
refactor-layered-resource-packs
branch
from
224e827 to
4e90526
Compare
Member
ShirleyNekoDev
left a comment
ShirleyNekoDev
left a comment
There was a problem hiding this comment.
The class LayeredResourcePacks sounds like it implements a similar interfaces as a "ResourcePack", maybe rename this to LayeredResourcePackContainer or something?
Otherwise this looks fine but I'd have to use it to see how I like it ^^
Member
Author
|
@ShirleyNekoDev Thanks for the review 😄 See #1728 for how it can be used. I renamed this class a few times… But in the end, it's "all resource packs you have" in one object, so I sticked with that name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, this makes loading painting variant and biome registries less hacky. In the future, this enables loading other files, eg. model json files, PBR maps or animation metadata.
Related to #751, #1332 and #1728