Use y-clipping settings from the map view when creating a new scene or loading chunks from it

[leMaik]

Also fixes requiring two reloads after changing the y-clipping settings of a scene.

Closes #1741

[Peregrine05]

Things seem slightly confusing now.

Chunky appears to use the Map Y clip when Load selected chunks or New scene from selection in the Map tab context menu is used, but it uses the Scene Y clip when Load selected chunks or Reload chunks in the Scene tab is used. Additionally, changing the Map Y clip while the Scene tab is open causes the Scene Y clip values to apparently reset to their default values; however, the internal values are not changed, and the UI values are set properly once it refreshes.

I think that either there should be one set of sliders that controls both the map view and the scene clip, or there should be two separate sets of sliders, as Chunky was previously, but with a note that points users to the Scene tab to change the Scene Y clip.

As I recall, the main issue was that the Scene Y clip values were not being set properly, which resulted in portions of the world not being loaded. Users would see the Map Y clip controls, and assume that they changed the Scene Y clip, so a note next to them, I believe, would be effective.

[leMaik]

Chunky appears to use the Map Y clip when Load selected chunks or New scene from selection in the Map tab context menu is used, but it uses the Scene Y clip when Load selected chunks or Reload chunks in the Scene tab is used.

@Peregrine05 This is exactly the intended behavior. I do see that it might be confusing if you create a scene from the left panel – I didn't consider that.

Additionally, changing the Map Y clip while the Scene tab is open causes the Scene Y clip values to apparently reset to their default values; however, the internal values are not changed, and the UI values are set properly once it refreshes.

That is not supposed to happen… I'll look into this. The scene tab is supposed to represent the scene state, regardless of whatever the map view does.

Users would see the Map Y clip controls, and assume that they changed the Scene Y clip, so a note next to them, I believe, would be effective.

Users would expect that the y clip controls from the map are applied when creating a new scene – which is what this PR does. After a scene has been created, the y clip (as well as any other scene settings) can be controlled in the scene tab.

two separate sets of sliders, as Chunky was previously, but with a note that points users to the Scene tab to change the Scene Y clip.

A UI that needs a note to explain how it works is the worst solution we could find.

[leMaik]

Edit: Changed it to "The map Y clip also applies to new scenes. To change the Y clip of the current scene, use the sliders in the Scene panel and then reload the chunks."

@Peregrine05 What do you think? 🤔

[Peregrine05]

Ah; so how it works now is:

Map right-click > New scene from selection: Use Map Y clip
Map right-click > Load selected chunks (First usage, equivalent to New scene from selection): Use Map Y clip
Scene tab > Load selected chunks: Use Scene Y clip

If so, I think should work well for the moment (a dialog box might be a better solution in the long run, but a dialog box also requires more user input to get the same job done, so this solution would be more convenient for the users).

[leMaik]

@Peregrine05 Exactly 💯

Regarding the dialog box: Yes, I also considered that, but the hint is mostly for first time users who don't know about the two sliders yet. Once they know, there's no reason to bother them with a dialog. But the content of a dialog with a "Don't show this again" checkbox might be forgotten at some point.

Let's roll with this and see if the y clip confusion is reduced. 🚀

Also regarding "y clip": Should we consistently rename this to "Y-clip"? Same for -axis etc.?

[Peregrine05]

I think that's a good idea, as it helps define the two separate words as a single "word".