Skip to content

Comments

Parse canvasConfig width and height if present#1840

Closed
Peregrine05 wants to merge 1 commit intochunky-dev:masterfrom
Peregrine05:load-scene-canvasConfig
Closed

Parse canvasConfig width and height if present#1840
Peregrine05 wants to merge 1 commit intochunky-dev:masterfrom
Peregrine05:load-scene-canvasConfig

Conversation

@Peregrine05
Copy link
Member

Chunky has a canvasConfig now, so this PR updates the scene parser in the scene loader dialog to use the canvasConfig width and height values, if present, and to fall back to the scene JSON root width and height otherwise.

@leMaik
Copy link
Member

leMaik commented Sep 14, 2025

The scene JSON does not have a canvasConfig object. The Java CanvasConfig object flattens its configuration into the root scene object.

@leMaik leMaik closed this Sep 14, 2025
@Peregrine05
Copy link
Member Author

Thanks for catching that. When I saw the issue present, I thought it would also be present on master (like with the resin bricks issue) but I forgot to actually check.

@leMaik
Copy link
Member

leMaik commented Sep 14, 2025

tbh I was confused for a moment too and had to check the code on master first 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants