Parse canvasConfig width and height if present#1840
Closed
Peregrine05 wants to merge 1 commit intochunky-dev:masterfrom
Closed
Parse canvasConfig width and height if present#1840Peregrine05 wants to merge 1 commit intochunky-dev:masterfrom
Peregrine05 wants to merge 1 commit intochunky-dev:masterfrom
Conversation
Member
|
The scene JSON does not have a |
Member
Author
|
Thanks for catching that. When I saw the issue present, I thought it would also be present on master (like with the resin bricks issue) but I forgot to actually check. |
Member
|
tbh I was confused for a moment too and had to check the code on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunky has a
canvasConfignow, so this PR updates the scene parser in the scene loader dialog to use thecanvasConfigwidthandheightvalues, if present, and to fall back to the scene JSON rootwidthandheightotherwise.