support ipv6 gateway on cloud init VMs#507
Open
moracca wants to merge 2 commits intochurchers:masterfrom
Open
Conversation
currently the network-config written for cloud init VMs is assuming that the gateway IP will be ipv4. This commit simply checks if the IP contains a `:` and changes to using gateway6 key in the network-config in this case
|
Does this work for you? |
Contributor
Author
|
Yes that should work fine. I've made that change. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently the network-config written for cloud init VMs is assuming that the gateway IP will be ipv4.
This commit simply checks if the IP contains a
:and changes to using gateway6 key in the network-config in this caseI am not certain if there are other places that might break IPv6 usage, but this was one place that seemed like an easy fix.