remove redundant w opt with ignore_msr

[ke5C2Fin]

With merged PR #525, we add -w to the default _opts on line 112 which makes checking config::yesno "ignore_msr" and conditionally adding w via && _opts="${_opts}w" on line 115 redundant.

Does something else need to be done for Model Specific Registers?
With the addition of w as default, nothing is then changed for msr, but I don't know what would be.

[bileslav]

Hi @ke5C2Fin,

In the vm.8 and config.sample there is no ignore_msr, but there is ignore_bad_msr. My proposal:

1. Fix the man page. In particular, reflect that ignore_bad_msr default (yes) is not limited to UEFI guests only.
2. Use this code:

# default bhyve options
_opts="-AHP"

# ignore access to unimplemented Model Specific Registers?
config::yesno "ignore_bad_msr" yes && _opts="${_opts}w"

humbly summoning @mateuszkwiatkowski