Skip to content

Adding ability to override defaults in config#1034

Open
mansona wants to merge 1 commit intocibernox:masterfrom
stonecircle:master
Open

Adding ability to override defaults in config#1034
mansona wants to merge 1 commit intocibernox:masterfrom
stonecircle:master

Conversation

@mansona
Copy link
Contributor

@mansona mansona commented Dec 4, 2017

This is only a proof of concept to see if you are happy with the idea, and if so we can extend it to all/any of the parameters you want to be able to set the defaults for in config.

The basic idea here is: you have a sensible default set for matchTriggerWidth on ember-power-select but I need this default to be different for all instances of ember-power-select across my codebase.

Using a trick similar to we use in ember-cli-notifications I have been able to test this locally with a linked ember-power-select. If you like the idea I can (try) implement some tests using https://github.com/tomdale/ember-cli-addon-tests.

@johanrd
Copy link
Contributor

johanrd commented Jan 20, 2026

I guess this exact PR is a but outdated with the v2 way of not accessing the config during runtime.

The basic way here is to use component extensions, but I am also curious if you know a more 'vite way' of overriding defaults here (or in general), @mansona?

@mkszepp
Copy link
Collaborator

mkszepp commented Jan 20, 2026

@johanrd today you need to extend the base power-select component and use in all places the extended component or making a wrapper component.

In future, we can do thinks like in this PR with setConfig, for example setConfig({ matchTriggerWidth: true }) to bring defaults in component... but we need to investigate whats happen, when somebody is chaning configs during runtime 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants