Prevent mouse click on input text from clearing text#1159
Open
zachary1006 wants to merge 1 commit intocibernox:masterfrom
Open
Prevent mouse click on input text from clearing text#1159zachary1006 wants to merge 1 commit intocibernox:masterfrom
zachary1006 wants to merge 1 commit intocibernox:masterfrom
Conversation
… typed into input field
Contributor
|
@cibernox Could you take a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #646, clicking inside a power-select-multiple input field after typing text clears the text. This proposed fix stops the propagation of the mousedown event if there is text in the input field.
To reproduce:
This issue can be seen on the Ember Power Select multiple-selection page (https://ember-power-select.com/docs/multiple-selection). To reproduce, type some text into the input field (do not press "Enter"). Then click your mouse in the input field, as though you were adjusting the cursor on a Word document. The text vanishes and the dropdown is closed.
Typing in the input
Text disappears on click
Expected behavior:
The cursor can be repositioned by clicking the mouse.
Cursor can be repositioned by clicking in the input