Skip to content

Remove ember-source and glimmer tracking as a peer dependency #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkszepp merged 1 commit into from
May 10, 2025
Merged

Remove ember-source and glimmer tracking as a peer dependency #1877

mkszepp merged 1 commit into from
May 10, 2025

Conversation

@runspired
Copy link
Contributor

@runspired runspired commented May 10, 2025

  • @glimmer/tracking is provided by ember-source
  • ember-source is assumed by both embroider and ember-cli in ways that it doesn't actually need to be a peer, and having it as one creates potential for duplicate copies that create errors in apps

@mkszepp
Copy link
Collaborator

mkszepp commented May 10, 2025 •
edited
Loading

Here more details, why we should do

ember-cli/ember-addon-blueprint#35

@mkszepp mkszepp changed the title fix: drop undesirable peers Remove ember-source as a peer dependency May 10, 2025
@mkszepp mkszepp merged commit e6301ab into cibernox:master May 10, 2025
20 checks passed
@mkszepp mkszepp changed the title Remove ember-source as a peer dependency Remove ember-source and glimmer tracking as a peer dependency May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@runspired @mkszepp