Copyright Action #10
Merged
Copyright Action #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronJhaj
requested changes
Feb 4, 2025
Contributor
AaronJhaj
left a comment
AaronJhaj
left a comment
There was a problem hiding this comment.
just a couple things to change
.github/workflows/java.yaml
Outdated
| - uses: actions/checkout@v3 | ||
| - name: Check Copyright | ||
| env: | ||
| EXTENSIONS: "*.java" |
Contributor
There was a problem hiding this comment.
please could you change the EXTENSIONS env variable to:
EXTENSIONS: "*.java *.js"
.github/workflows/java.yaml
Outdated
| COPYRIGHT_STATEMENT: "/**\n * Copyright IBM Corp. 2024\n */" | ||
| run: | | ||
| for ext in $EXTENSIONS; do | ||
| for file in $(find . -type f -name "$ext" ! -path "cics-java-liberty-jdbc/*"); do |
Contributor
There was a problem hiding this comment.
please change the path to be "cics-java-liberty-jdbc-web/*"
IvanHargreaves
approved these changes
Feb 4, 2025
Contributor
IvanHargreaves
left a comment
IvanHargreaves
left a comment
There was a problem hiding this comment.
Approving as long as Aaron's comments are addressed. Thanks.
Contributor
|
NOTE: once you add the *.js to the EXTENSIONS list, the build should create another pull request with the copyright added the to .js file. merge that into this branch before merging this pr |
Changes by create-pull-request action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cics-java-liberty-jdbc Copyright action.