-
Notifications
You must be signed in to change notification settings - Fork 1
Aj 6.1 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aj 6.1 #20
Conversation
IvanHargreaves
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one base library issue in comments.
IvanHargreaves
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are base-lining on V6.1, we need to consider which EE level we are base-lining on too, and therefore what Java level will work, what feature levels we say to add in the server.xml, what Java/Liberty libraries are on the classpath of the Eclipse Project App, which versions of EE are pulled into the Gradle and POM stuff, and what xml namespace is used in the web.xml too. They all need to be made consistent and compatible, and then reflected in the README.
|
now that we are basing on java 17, i have removed java 8 and 11 from the gh action build |
IvanHargreaves
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a couple of review comments, but note you've moved things to Jakarta EE 9, which is fine for now, until we get Explorer updated - then we should go to EE 10.
cics-java-liberty-jdbc-web/.settings/org.eclipse.jdt.core.prefs
Outdated
Show resolved
Hide resolved
cics-java-liberty-jdbc-web/.settings/org.eclipse.wst.common.project.facet.core.xml
Outdated
Show resolved
Hide resolved
IvanHargreaves
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, maybe I reviewed too soon, it looks sorted now. Great.
No description provided.