Skip to content

Conversation

@AaronJhaj
Copy link
Contributor

No description provided.

@AaronJhaj AaronJhaj self-assigned this May 27, 2025
@AaronJhaj AaronJhaj requested a review from IvanHargreaves May 27, 2025 08:43
Copy link
Contributor

@IvanHargreaves IvanHargreaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one base library issue in comments.

@AaronJhaj AaronJhaj requested a review from IvanHargreaves May 27, 2025 11:03
Copy link
Contributor

@IvanHargreaves IvanHargreaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are base-lining on V6.1, we need to consider which EE level we are base-lining on too, and therefore what Java level will work, what feature levels we say to add in the server.xml, what Java/Liberty libraries are on the classpath of the Eclipse Project App, which versions of EE are pulled into the Gradle and POM stuff, and what xml namespace is used in the web.xml too. They all need to be made consistent and compatible, and then reflected in the README.

@AaronJhaj
Copy link
Contributor Author

now that we are basing on java 17, i have removed java 8 and 11 from the gh action build

@AaronJhaj AaronJhaj requested a review from IvanHargreaves May 28, 2025 13:37
Copy link
Contributor

@IvanHargreaves IvanHargreaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of review comments, but note you've moved things to Jakarta EE 9, which is fine for now, until we get Explorer updated - then we should go to EE 10.

@AaronJhaj AaronJhaj requested a review from IvanHargreaves May 28, 2025 16:43
Copy link
Contributor

@IvanHargreaves IvanHargreaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, maybe I reviewed too soon, it looks sorted now. Great.

@AaronJhaj AaronJhaj merged commit e39ef86 into cicsts/v6.1 May 29, 2025
5 checks passed
@AaronJhaj AaronJhaj deleted the aj-6.1 branch May 29, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants