Merged
Conversation
This change improves ariane feedback following a trigger phrase which dependencies haven't been met. If the dependency is still running - Ariane reacts to comment with a "+1" emoji to indicate that everything is fine and the trigger will be run after dependencies are complete. In verbose mode the comment is changed to be less negative. If the dependency failed - Ariane reacts to comment with a "confused" emoji which indicates that tests won't be triggered. In verbose mode the comment stays negative as it was. Signed-off-by: Maciej Kwiek <mkwiek@cisco.com>
nebril
force-pushed
the
pr/nebril/fix-dependency-comment
branch
from
cf22771 to
e719b55
Compare
nbusseneau
approved these changes
Mar 13, 2026
Member
nbusseneau
left a comment
nbusseneau
left a comment
There was a problem hiding this comment.
LGTM, we can extend this as we identify more cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves ariane feedback following a trigger phrase which dependencies haven't been met.
If the dependency is still running - Ariane reacts to comment with a "+1" emoji to indicate that everything is fine and the trigger will be run after dependencies are complete.
In verbose mode the comment is changed to be less negative.
If the dependency failed - Ariane reacts to comment with a "confused" emoji which indicates that tests won't be triggered.
In verbose mode the comment stays negative as it was.