Always update github.com/cilium/cilium from main #2951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, renovate will try to update to the latest patch release, i.e. 1.17.1 at the moment but the stable branches on github.com/cilium/cilium don't contain the cilium-cli/ directory, thus breaking the build on update PRs, see e.g. #2948 Instead, we should always be vendoring the latest version from main. Drop the renovate configuration accordingly and instead update the github.com/cilium/cilium dependency upon release of a new cilium-cli version. Signed-off-by: Tobias Klauser <[email protected]>
michi-covalent
approved these changes
Feb 25, 2025
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added a commit
that referenced
this pull request
Feb 26, 2025
The only direct dependency in go.mod is github.com/cilium/cilium which is updated manually before release (see #2951). The Go version in go.mod is already excluded from being updated by renovate and because there are no other modules to update anymore we can omit go.mod from being updated by renovate altogether. Also remove some leftover configuration that no longer applies as a result of the merge of cilium-cli into github.com/cilium/cilium. Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added a commit
that referenced
this pull request
Feb 26, 2025
The only direct dependency in go.mod is github.com/cilium/cilium which is updated manually before release (see #2951). The Go version in go.mod is already excluded from being updated by renovate and because there are no other modules to update anymore we can omit go.mod from being updated by renovate altogether. Also remove some leftover configuration that no longer applies as a result of the merge of cilium-cli into github.com/cilium/cilium. Signed-off-by: Tobias Klauser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, renovate will try to update to the latest patch release, i.e. 1.17.1 at the moment but the stable branches on github.com/cilium/cilium don't contain the cilium-cli/ directory, thus breaking the build on update PRs, see e.g. #2948
Instead, we should always be vendoring the latest version from main. Drop the renovate configuration accordingly and instead update the github.com/cilium/cilium dependency upon release of a new cilium-cli version.