ringbuf: context support #1937
Open
ringbuf: context support #1937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.cloud>
florianl
reviewed
Jan 16, 2026
| // Returns [os.ErrDeadlineExceeded] if a deadline was set and no wakeup was received. | ||
| // Returns [ErrFlushed] if the ring buffer was flushed manually. | ||
| // Returns [os.ErrClosed] if the poller was closed. | ||
| func (p *poller) Wait(deadline time.Time) error { |
Contributor
There was a problem hiding this comment.
Can you elaborate more a bit on why this change is needed for your case?
As you show, with SetDeadline() in on of the tests, a similar behaviour can be achieved.
Author
There was a problem hiding this comment.
My use case would be to stop blocking if a context, e.g. from a http request, is canceled.
I found the SetDeadline() function a bit misleading for that use case, because then the application would need to handle the context cancel correctly and use the function with time.Now().
Passing contexts down to subfunction calls felt easier instead of handling it on the application side.
Maybe there is a better take to handle this, I am open for discussion :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support canceling ringbuf epoll using a context.