Draft
Conversation
andrewstrohman
added
the
release-note/minor
andrewstrohman
force-pushed
the
pr/andrewstrohman/refactor-resolve
branch
10 times, most recently
from
e5ecf85 to
549f7da
Compare
When we want to resolve a precise index of an array, like for example `do_pipe2` with `resolve: "[1]"`, we want to skip nested pointer logic, since we are already going to dereference the correct index. Also, updated `TestResolveBTFArgFromKprobePolicy` to test the behavior. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Refactor so that we have have one test per argument type. Since we are limited to configuring 5 arguments, we were limited to testing 5 argument types per test. It's also easier to debug one argument type per test. Signed-off-by: Andy Strohman <astrohma@isovalent.com>
To cover a pointer to an int and a pointer to string at the end of the resolve path. Signed-off-by: Andy Strohman <astrohma@isovalent.com>
andrewstrohman
force-pushed
the
pr/andrewstrohman/refactor-resolve
branch
2 times, most recently
from
d61c3cf to
863fb3c
Compare
To cover nested anonymous unions and structs. Signed-off-by: Andy Strohman <astrohma@isovalent.com>
Test that nested anonymous unions and structs work. Signed-off-by: Andy Strohman <astrohma@isovalent.com>
We do not support dynamic arrays of pointers, so adjust the test to reflect this. Signed-off-by: Andy Strohman <astrohma@isovalent.com>
From a BTF perspective, the 2D array gets flattened to a 1D array. This test demonstrates how to configure resolve in order to locate the correct element. Signed-off-by: Andy Strohman <astrohma@isovalent.com>
andrewstrohman
force-pushed
the
pr/andrewstrohman/refactor-resolve
branch
from
863fb3c to
de2d01e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Description
Changelog