Merged
Conversation
The row bytes calculation was incorrectly using sizeof(float) instead of sizeof(uint8_t) for UINT8 data types, causing incorrect buffer sizes.
…ation - Replace raw COM pointers with msw::ComPtr for automatic lifetime management - Use releaseAndGetAddressOf() for COM output parameters - Remove overly restrictive static_assert from ComPtr that prevented compilation with forward-declared types - Implement dynamic WIC decoder/encoder enumeration to automatically register supported extensions - WIC now queries installed codecs at registration time instead of using hardcoded extension list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update changes the way we interact with WIC on Windows for image reading and writing. Rather than the hard-coded set of supported codecs we've had in the past, we now dynamically query what codecs are available on the machine. Under both Windows 10 and Windows 11, this adds a number of new formats without any changes to your app code.
As compared to previous versions, on Windows 11 this PR adds the following source formats:
and adds the following output formats:
This PR also handles correct handling for a number of new image formats,