fix: Add decryption to screening - #2
Merged
aegis-cipherowl merged 4 commits intoApr 13, 2026
Merged
Conversation
HenryMBaldwin
force-pushed
the
h/decryption-for-cipherowl
branch
from
March 30, 2026 15:37
c553462 to
74fa442
Compare
HenryMBaldwin
marked this pull request as ready for review
March 30, 2026 18:23
cdrappi
approved these changes
Mar 30, 2026
| fail_mode = %args.fail_mode, | ||
| "Address screening enabled via ECSD sidecar" | ||
| ); | ||
| let purpose_keys = crate::purpose_keys::get_purpose_keys(); |
There was a problem hiding this comment.
i believe this should be robust to purpose keys changing
| where | ||
| T: PoolTransaction + alloy_consensus::Transaction, | ||
| { | ||
| extract_addresses_with_input(tx, tx.input()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds decryption to screening in response to
this comment.
For transactions requiring decryption, it will be attempted. If decryption
succeeds, it will be screened as normal. If decryption fails, it will enter the
pool unscreened.