CI: fix typo causing only ignored tests to run #104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes up a typo in the test workflow in CI that's causing only ignored tests to run. Confusingly, `--ignored` runs *only* ignored tests, but `--include-ignored` runs tests whether they're ignored or not. `--include-ignored` is probably what we want. Even more confusingly, the `--ignored` and `--include-ignored` flags don't seem to be well documented, but it is mentioned in The Book here: https://doc.rust-lang.org/book/ch11-02-running-tests.html#ignoring-some-tests-unless-specifically-requested.
CDThomas
changed the title
|
Example of a workflow where only ignored tests ran: https://github.com/cipherstash/cipherstash-dynamodb/actions/runs/15105808245/job/42454292964#step:6:681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes up a typo in the test workflow in CI that's causing only ignored tests to run.
Confusingly,
--ignoredruns only ignored tests, but--include-ignoredruns tests whether they're ignored or not.--include-ignoredis probably what we want.Even more confusingly, the
--ignoredand--include-ignoredflags don't seem to be well documented, but it is mentioned in The Book here: https://doc.rust-lang.org/book/ch11-02-running-tests.html#ignoring-some-tests-unless-specifically-requested.